Fix selection for group modal

[benjaminpkane]

What changes are proposed in this pull request?

Sample selection currently interferes with the group modal by filtering out slices that a user should still see

How is this patch tested? If it is not, please explain why.

New server_group_tests.py case

import fiftyone as fo
import fiftyone.zoo as foz

dataset = foz.load_zoo_dataset("quickstart-groups")
# all slices should display in the modal
session = fo.launch_app(dataset.select(dataset.first().id))

Release Notes

• Fixed missing slices in the expanded view for :ref:grouped datasets <groups> when a sample selection is present

What areas of FiftyOne does this PR affect?

• App: FiftyOne application changes
• Build: Build and test infrastructure changes
• Core: Core fiftyone Python library changes
• Documentation: FiftyOne documentation changes
• Other

Summary by CodeRabbit

• New Features

  • Enhanced group selection functionality for improved filtering in views.

• Tests

  • Added a new test case to validate group selection and filtering behavior.

[coderabbitai]

Walkthrough

The changes involve modifications to the handle_group_filter function in fiftyone/server/view.py, specifically adding a conditional check to filter out certain stages during group selection. Additionally, a new test method, test_group_selection, is introduced in tests/unittests/server_group_tests.py to validate the functionality of group selection within a dataset, ensuring that the filtering logic operates correctly.

Changes

Files	Change Summary
fiftyone/server/view.py	Modified handle_group_filter to add a conditional check for filtering stages during group selection.
tests/unittests/server_group_tests.py	Added test_group_selection to validate group selection functionality and filtering logic.

Poem

In the meadow where we play,
A filter's dance has found its way.
With groups selected, stages clear,
Our dataset hops without a fear.
So let us cheer, oh what a sight,
For changes made to bring delight! 🐇✨

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 41ed515 and 8afe2b9.

Files selected for processing (1)

• fiftyone/server/view.py (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• fiftyone/server/view.py

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sashankaryal]

lgtm!