-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes v1.0.0 #4839
Release notes v1.0.0 #4839
Conversation
WalkthroughThe pull request updates the release notes for FiftyOne Teams 2.1.0 and FiftyOne 1.0.0, both released on October 1, 2024. Key enhancements include new super admin features, performance optimizations, and bug fixes. The release notes also highlight significant updates such as the open-sourcing of FiftyOne Brain, new UI components, and improvements to dataset management. Additionally, deprecated methods and Python 3.8 support have been addressed. Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure?
3f9a235
to
20118a8
Compare
20118a8
to
027d119
Compare
2658b95
to
59e2cba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
docs/source/user_guide/using_datasets.rst (1)
Line range hint
1663-1685
: Well-explained problem and solution for efficient querying.This section effectively outlines the inefficiency of directly querying frame-level fields in large datasets and introduces the
create_summary_field()
method as a solution. The explanation is clear, and the code examples demonstrate the usage well.Consider adding a brief comment in the code example to explain what the
frames_detections_label
field represents after it's created. This would help users understand the output more clearly.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
⛔ Files ignored due to path filters (1)
docs/source/images/datasets/quickstart-video-summary-fields.gif
is excluded by!**/*.gif
,!**/*.gif
📒 Files selected for processing (5)
- docs/scripts/make_model_zoo_docs.py (2 hunks)
- docs/source/deprecation.rst (1 hunks)
- docs/source/plugins/developing_plugins.rst (4 hunks)
- docs/source/release-notes.rst (1 hunks)
- docs/source/user_guide/using_datasets.rst (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
- docs/scripts/make_model_zoo_docs.py
- docs/source/deprecation.rst
- docs/source/plugins/developing_plugins.rst
- docs/source/release-notes.rst
🔇 Additional comments (3)
docs/source/user_guide/using_datasets.rst (3)
1638-1645
: Clear and informative introduction to summary fields.This addition provides a concise explanation of summary fields and their purpose in FiftyOne datasets. It effectively sets the context for the following example and highlights the benefits of using summary fields for efficient querying on large datasets.
1657-1662
: Helpful visual demonstration added.The inclusion of the code snippet to launch the FiftyOne app and the accompanying image of the quickstart-video dataset enhances the documentation. This visual aid helps users better understand the context and appearance of the dataset being discussed.
1764-1785
: Effective conclusion and helpful App-related information.This section provides a strong conclusion to the explanation of summary fields, emphasizing their benefits for performant filtering. The added note about summary fields being automatically organized in the App's sidebar is particularly useful for users working with the FiftyOne App interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
docs/source/index.rst (1)
184-187
: LGTM! Consider adding an integration page for Segments.The addition of the Segments integration looks good and follows the established pattern for custom image links in this file. The positioning and content are appropriate.
For consistency with other integrations, consider creating a dedicated integration page for Segments (e.g.,
integrations/segments.html
) and updating the:image_link:
to point to this new page instead of directly to the GitHub repository. This would provide users with more detailed information about the integration within the FiftyOne documentation.
133f7f5
to
70aead6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure thing!
Summary by CodeRabbit
New Features
Bug Fixes
Documentation