Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make icon in panel table have circle background on hover #5197

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

CamronStaley
Copy link
Contributor

@CamronStaley CamronStaley commented Nov 27, 2024

What changes are proposed in this pull request?

make icon in panel table have circle background on hover

How is this patch tested? If it is not, please explain why.

2024-11-27 15 40 25

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Summary by CodeRabbit

  • New Features

    • Enhanced rendering logic for the ActionsMenu component, allowing for more flexible UI behavior based on the presence of labels.
    • Improved visual consistency in the TableView component by maintaining row height even when no actions are available.
  • Bug Fixes

    • Adjusted conditional rendering to ensure proper display of action buttons and maintain layout integrity.

Copy link
Contributor

coderabbitai bot commented Nov 27, 2024

Walkthrough

The pull request introduces modifications to the ActionsMenu and TableView components. In ActionsMenu.tsx, the rendering logic for buttons has been updated to conditionally display either a Button or an IconButton based on the presence of a label. In TableView.tsx, the rendering of the ActionsMenu is adjusted to maintain consistent row heights, ensuring an empty Box is shown when no actions are available. Both components retain their core functionality and structure.

Changes

File Path Change Summary
app/packages/core/src/plugins/SchemaIO/components/ActionsMenu.tsx - Updated rendering logic for Action component to conditionally render Button or IconButton based on label prop.
- Reformatted MuiIconFont props for readability.
- Improved overall structure for clarity.
app/packages/core/src/plugins/SchemaIO/components/TableView.tsx - Modified rendering logic of row actions to use a ternary operation for displaying ActionsMenu or an empty Box to ensure consistent row height.
- getRowActions function remains unchanged.

Possibly related PRs

Suggested reviewers

  • minhtuev
  • ritch

🐰 In the meadow where actions play,
A button hops, then hides away.
With icons bright and boxes tall,
The menu dances, pleasing all.
A tweak here, a change there,
Consistency's the name we share! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@minhtuev minhtuev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work thanks Cam! ✅

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9f690fe and 0efe9f7.

📒 Files selected for processing (2)
  • app/packages/core/src/plugins/SchemaIO/components/ActionsMenu.tsx (2 hunks)
  • app/packages/core/src/plugins/SchemaIO/components/TableView.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
app/packages/core/src/plugins/SchemaIO/components/ActionsMenu.tsx (1)

Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

app/packages/core/src/plugins/SchemaIO/components/TableView.tsx (1)

Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

🔇 Additional comments (2)
app/packages/core/src/plugins/SchemaIO/components/TableView.tsx (2)

225-232: LGTM! Good improvement for consistent row heights.

The empty Box with minHeight ensures consistent row heights across the table, which improves the visual stability of the UI.


225-232: Verify the hover effect implementation in ActionsMenu component.

While this change maintains consistent row heights, the circular background hover effect mentioned in the PR objective should be implemented in the ActionsMenu component.

Comment on lines +112 to +120
<IconButton
onClick={handleClick}
size={size}
sx={{
color: resolvedColor,
}}
>
{Icon}
</IconButton>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Ensure consistent hover effects

The IconButton should have the same circular hover effect as the icon itself for visual consistency.

Add hover styling to the IconButton:

 <IconButton
   onClick={handleClick}
   size={size}
   sx={{
     color: resolvedColor,
+    '&:hover': {
+      backgroundColor: 'action.hover',
+      borderRadius: '50%',
+    },
   }}
 >
   {Icon}
 </IconButton>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<IconButton
onClick={handleClick}
size={size}
sx={{
color: resolvedColor,
}}
>
{Icon}
</IconButton>
<IconButton
onClick={handleClick}
size={size}
sx={{
color: resolvedColor,
'&:hover': {
backgroundColor: 'action.hover',
borderRadius: '50%',
},
}}
>
{Icon}
</IconButton>

Comment on lines +81 to +86
<MuiIconFont
name={icon}
sx={{
color: resolvedColor,
}}
/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Add hover effect with circle background

The current styling doesn't implement the circular background on hover as specified in the PR objectives.

Add hover styling to match the requirements:

 <MuiIconFont
   name={icon}
   sx={{
     color: resolvedColor,
+    borderRadius: '50%',
+    '&:hover': {
+      backgroundColor: 'action.hover',
+    },
   }}
 />
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<MuiIconFont
name={icon}
sx={{
color: resolvedColor,
}}
/>
<MuiIconFont
name={icon}
sx={{
color: resolvedColor,
borderRadius: '50%',
'&:hover': {
backgroundColor: 'action.hover',
},
}}
/>

@CamronStaley CamronStaley merged commit 7287351 into release/v1.1.0 Nov 27, 2024
10 checks passed
@CamronStaley CamronStaley deleted the panel/icon-on-hover branch November 27, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants