Fixes sort in model eval display option and enables "display options" in table view

[manivoxel51]

What changes are proposed in this pull request?

• Shows the cog settings for Display Options in table view as well as chart view.
• Sorting a-z and z-a both were showing z-a results.

How is this patch tested? If it is not, please explain why.

Uploading Screen Recording 2025-01-09 at 1.17.58 PM.mov…

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

• No. You can skip the rest of this section.
• Yes. Give a description of this change to be included in the release
  notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

• App: FiftyOne application changes
• Build: Build and test infrastructure changes
• Core: Core fiftyone Python library changes
• Documentation: FiftyOne documentation changes
• Other

Summary by CodeRabbit

• New Features

  • Improved settings icon visibility in class performance section
  • Enhanced sorting logic for class performance metrics

• Bug Fixes

  • Refined sorting behavior to ensure consistent ascending order
  • Standardized settings icon rendering across different modes

The changes provide a more consistent and user-friendly interface for viewing model evaluation results.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the Evaluation component in the NativeModelEvaluationView. The changes primarily focus on two key aspects: consistently rendering the settings icon and refining the sorting logic for class performance metrics. The modifications ensure that the settings icon is always visible, regardless of the class mode, and improve the sorting mechanism for performance data by standardizing the "az" sorting approach.

Changes

File	Change Summary
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx	- Removed conditional rendering for settings icon - Modified formatPerClassPerformance sorting logic - Ensured consistent "az" sorting behavior

Possibly related PRs

• various model evaluation fixes and enhancements #5123: Enhances Evaluation component functionality and configurability
• model evaluation bug fixes #5166: Introduces dialog configurations for class performance settings
• fix confusion matrix in model evaluation panel #5186: Addresses confusion matrix issues in the Evaluation component
• bugfix: y-axis autorange reversed on all evaluation chart #5193: Modifies layout configurations for confusion matrices
• Optimize view callbacks for model evaluation panel #5268: Optimizes view callbacks and interaction logic
• Model evaluation panel fixes and enhancements #5281: Introduces error handling for evaluation data

Suggested Reviewers

• imanjra
• brimoor

Poem

🐰 In the realm of metrics and code,
A settings icon finds its abode
Sorting classes with grace and might
Performance metrics now shine bright
A rabbit's tale of UI delight! 🔍

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx (1)

1655-1658: Improve code maintainability in sorting logic.

While the sorting implementation is functionally correct, the code structure could be improved for better maintainability.

Consider applying this diff to maintain consistent if-else structure:

      } else if (sortBy === "az") {
        return a.property.localeCompare(b.property);
-      }
-      return b.property.localeCompare(a.property);
+      } else if (sortBy === "za") {
+        return b.property.localeCompare(a.property);
+      }
+      return 0; // default case

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 60971f8 and 36bc7e3.

📒 Files selected for processing (1)

• app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx (1)

Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

🔇 Additional comments (1)

app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx (1)

1062-1071: LGTM! Settings icon implementation looks good.

The implementation follows React best practices and successfully enables display options in both chart and table views.

[imanjra]

LGTM