Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct frame collection aggregations for expanded sample view #5386

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
3 changes: 2 additions & 1 deletion app/packages/app/src/index.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ErrorBoundary, ThemeProvider } from "@fiftyone/components";
import { BeforeScreenshotContext, screenshotCallbacks } from "@fiftyone/state";
import { SnackbarProvider } from "notistack";
import type React from "react";
import React from "react";
import { createRoot } from "react-dom/client";
import { RecoilRoot } from "recoil";
import Network from "./Network";
Expand All @@ -14,6 +14,7 @@ const App: React.FC = () => {
return <Network environment={environment} context={context} />;
};


createRoot(document.getElementById("root") as HTMLDivElement).render(
<RecoilRoot>
<ThemeProvider>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { useTrackEvent } from "@fiftyone/analytics";
import { useClearModal } from "@fiftyone/state";
import {
GraphQLError,
Expand All @@ -18,7 +19,6 @@ import { scrollable } from "../../scrollable.module.css";
import CodeBlock from "../CodeBlock";
import Loading from "../Loading";
import style from "./ErrorBoundary.module.css";
import { useTrackEvent } from "@fiftyone/analytics";

type AppError = GraphQLError | NetworkError | NotFoundError | ServerError;

Expand All @@ -34,7 +34,8 @@ const Errors = (onReset?: () => void, disableReset?: boolean) => {
const clearModal = useClearModal();
useLayoutEffect(() => {
clearModal();
}, []);
document.getElementById("modal")?.classList.remove("modalon");
}, [clearModal]);

if (error instanceof NotFoundError) {
return <Loading>{error.message}</Loading>;
Expand Down
Loading