Fix error handling in query()? #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an error handler is provided, use it. Otherwise propagate the Error up the stack. Prior to this, error handler was ignored, and all Errors caught in query() were rethrown.
alxndrsn
force-pushed
the
remove-unused-argument
branch
from
ecc401b
to
9f155ac
Compare
voxpelli
added a commit
that referenced
this pull request
Aug 19, 2020
|
Thanks @alxndrsn! I took a look at the history of the file and decided to revert the function to the state it was prior to refactoring, but many thanks for making a PR 🙏 I also added tests for this case, so it won't appear again. |
|
Great, looks like it works - thanks for the quick fix & new release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On updating to latest
node-connect-pg-simple, I started seeing manyUnhandledPromiseRejectionWarnings when running out of database connections.Looking into the code, it seems like the
query()function is throwing errors when they should be handled internally.Is this a bug, or have I misunderstood what's going on?