Add ContainerPodman class #130
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
=======================================
Coverage 86.37% 86.37%
=======================================
Files 1 1
Lines 279 279
=======================================
Hits 241 241
Misses 38 38 ☔ View full report in Codecov by Sentry. |
bastelfreak
force-pushed
the
foo
branch
2 times, most recently
from
c10ebad to
1384f6b
Compare
|
Given there's no difference, I wonder if this is a benefit. Would it make sense to go the other direction and use |
|
I've no opinions here. I'm fine with every implementation. |
|
FWIW, I also think that this being |
|
Or, we keep the gem |
|
@evgeni like this? And then use container_podman as hypervisor in GHA-puppet and not docker_podman? |
| require 'beaker/hypervisor/docker' | ||
|
|
||
| module Beaker | ||
| class ContainerPodman < Beaker::Docker |
There was a problem hiding this comment.
mhm or should it inherit from Beaker::Container?
There was a problem hiding this comment.
Technically, Beaker::Container, not that it makes a difference today…
Yepp |
There was a problem hiding this comment.
I think this is a good start, but I'd lean to:
- Rename
Beaker::DockertoBeaker::Container - Introduce
Beaker::ContainerDocker,Beaker::ContainerPodmanandBeaker::ContainerSwamthat inherit fromBeaker::Container
Then deprecate Beaker::Docker. At first we can keep all the code in a single class but later we can differentiate in different ways.
This allows us to set the beaker hypervisor not only to `docker`, but also to `docker_podmand`. This enables us to implement podman specific patches (if we ever need to). But it also makes it easier for modules to specify if they want to use podman or docker. See voxpupuli/gha-puppet#48 for reference.
This allows us to set the beaker hypervisor not only to
docker, but also todocker_podman. This enables us to implement podman specific patches (if we ever need to). But it also makes it easier for modules to specify if they want to use podman or docker. See voxpupuli/gha-puppet#48 for reference.