Add docker_image_commands to debian10 with docker #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
test this please |
|
@smcelmurry I didn't find any existing tests to extend |
|
Oh so sorry @Dan33l, that is just the command for us to kick off our automated tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the moment it looks to be impossible to run acceptance with Beaker on Debian10 and Docker :
https://travis-ci.org/voxpupuli/puppet-letsencrypt/jobs/564849203#L1208
The command
wgetused to get thepuppet-agentis not present.This PR add a section
docker_image_commandsto Debian10.I removed
systemd-sysvi suppose it is not useful now.