Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(IMAGES-1334) Add support for macOS 12 #245

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

AriaXLi
Copy link
Contributor

@AriaXLi AriaXLi commented Feb 18, 2022

No description provided.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #245 (23359d3) into master (08f6074) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #245      +/-   ##
=========================================
- Coverage    0.52%   0.52%   -0.01%     
=========================================
  Files          14      14              
  Lines        2477    2485       +8     
=========================================
  Hits           13      13              
- Misses       2464    2472       +8     
Impacted Files Coverage Δ
lib/beaker-hostgenerator/data.rb 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f6074...23359d3. Read the comment docs.

@joshcooper
Copy link
Contributor

Hi @ekohl @bastelfreak our team is taking over for night's watch, so let us know if there's something we should be doing differently.

Also I found yaml/libyaml#46 which explains why sometimes the fixtures have a trailing space for expected_exception: \n. Hopefully that version of libyaml will be released in a ruby version and we can standardize on omitting the trailing space, so the output is stable.

@bastelfreak
Copy link
Member

@joshcooper looks good to me. if you review PRs you can also add the appropriate bug/enhancement/backwards-inconpatible label.

@bastelfreak bastelfreak merged commit 8bd2e39 into voxpupuli:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants