Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows 11 Enterprise, Fedora 36 #253

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

mhashizume
Copy link
Contributor

Supercedes this PR while we wait for macOS M1 testing infrastructure to become available.

0419963 is in response to this comment from @ekohl

cthorn42 and others added 2 commits June 22, 2022 13:53
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #253 (0419963) into master (a6115fc) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master    #253      +/-   ##
=========================================
- Coverage    0.52%   0.52%   -0.01%     
=========================================
  Files          14      14              
  Lines        2485    2495      +10     
=========================================
  Hits           13      13              
- Misses       2472    2482      +10     
Impacted Files Coverage Δ
lib/beaker-hostgenerator/data.rb 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6115fc...0419963. Read the comment docs.

@cthorn42
Copy link
Contributor

Are the white space changes intended in lib/beaker-hostgenerator/data.rb?

@mhashizume
Copy link
Contributor Author

Are the white space changes intended in lib/beaker-hostgenerator/data.rb?

Yes, 0419963 is in response to #252 (comment) from @ekohl. Happy to remove the commit if it makes codecov too grumpy.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be honest and say that codecov should probably be removed in this repo. It can't really detect a lot of the situations which leads to false positives. As for the alignment: Rubocop can detect it (and fix if needed) so that may be a good idea to look at in the future.

@mhashizume mhashizume merged commit e21f334 into voxpupuli:master Jun 22, 2022
@mhashizume mhashizume deleted the maint/master/add_oses branch June 22, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants