Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlmaLinux: Fix docker image names #265

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak self-assigned this Dec 14, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 0.50% // Head: 0.50% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (ca85f1b) compared to base (d0372c6).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head ca85f1b differs from pull request most recent head 8f25140. Consider uploading reports for the commit 8f25140 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #265      +/-   ##
=========================================
- Coverage    0.50%   0.50%   -0.01%     
=========================================
  Files          15      15              
  Lines        2558    2560       +2     
=========================================
  Hits           13      13              
- Misses       2545    2547       +2     
Impacted Files Coverage Δ
lib/beaker-hostgenerator/data.rb 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this (and Rocky) be fixed here:

base_config['image'] = node_info['ostype'].sub(/(\d)/, ':\1')
base_config['image'].sub!(/\w+/, 'oraclelinux') if node_info['ostype'] =~ /^oracle/
base_config['image'].sub!(/(\w+)/, '\1/leap') if node_info['ostype'] =~ /^opensuse/
base_config['image'].sub!(/(\d{2})/, '\1.') if node_info['ostype'] =~ /^ubuntu/

By now you could probably make it a case statement.

@bastelfreak bastelfreak merged commit 24cc657 into voxpupuli:master Dec 14, 2022
@bastelfreak bastelfreak deleted the alma branch December 14, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants