Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop nfs_server and consoleport defaults #271

Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Feb 20, 2023

Beaker defaults to consoleport 443, so specifying this is redundant and extremely noisy.

As for nfs_server, I could not find any code that uses it. It shows up in many markdown files and configs, but I've yet to find actual Ruby code that uses it.

Beaker defaults to consoleport 443, so specifying this is redundant and
extremely noisy.

As for nfs_server, I could not find any code that uses it. It shows up
in many markdown files and configs, but I've yet to find actual Ruby
code that uses it.
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 0.50% // Head: 0.50% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (629109c) compared to base (f990ac3).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 629109c differs from pull request most recent head 276c0e1. Consider uploading reports for the commit 276c0e1 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #271   +/-   ##
======================================
  Coverage    0.50%   0.50%           
======================================
  Files          15      15           
  Lines        2565    2562    -3     
======================================
  Hits           13      13           
+ Misses       2552    2549    -3     
Impacted Files Coverage Δ
lib/beaker-hostgenerator/data.rb 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bastelfreak
Copy link
Member

mhm maybe that's only used internally at Puppet?

@ekohl
Copy link
Member Author

ekohl commented Feb 20, 2023

Possible, but I think the should fix the tool to have a default then instead of requiring it to be specified everywhere.

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The beginning looks okay, but my browser crash when I try to scroll down :-D Adding .diff at the end of the URI helps.

This look reasonable to me.

@ekohl
Copy link
Member Author

ekohl commented Feb 21, 2023

I should have mentioned that it was mostly:

find test/fixtures -type f -exec sed -i '/consoleport: 443/d' {} +
find test/fixtures -type f -exec sed -i '/nfs_server: none/d' {} +

Then I fixed up 3 fixtures where CONFIG became nil instead of {}.

@bastelfreak bastelfreak merged commit e10e11c into voxpupuli:master Feb 21, 2023
@ekohl ekohl deleted the drop-default-nfs_server-and-consoleport branch February 21, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants