add freebsd data #282
add freebsd data #282
Conversation
Codecov ReportBase: 0.50% // Head: 0.50% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #282 +/- ##
=========================================
- Coverage 0.50% 0.50% -0.01%
=========================================
Files 15 15
Lines 2553 2560 +7
=========================================
Hits 13 13
- Misses 2540 2547 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lib/beaker-hostgenerator/data.rb
Outdated
| @@ -685,6 +685,22 @@ def osinfo | |||
| 'platform' => 'fedora-14-i386', | |||
| }, | |||
| }, | |||
| 'freebsd12-64' => { | |||
| :general => { | |||
| 'platform' => 'freebsd-12-amd64', | |||
There was a problem hiding this comment.
I don't exactly understand the "platform" string. amd64 is FreeBSD way to say x86_64 (like Debian), but in other places I've seen this still being used as freebsd-123-x86_64, so no idea…
There was a problem hiding this comment.
I always struggle with this myself and need to dig through the code or wait for the awesome ewoud...
There was a problem hiding this comment.
the failures in https://github.com/voxpupuli/puppet-mosquitto/actions/runs/4269959304/jobs/7433482798 used freebsd-123-amd64, so I am going to stick with that for now.
There was a problem hiding this comment.
lib/beaker-hostgenerator/data.rb
Outdated
| 'platform' => 'freebsd-12-amd64', | ||
| }, | ||
| :vagrant => { | ||
| 'box' => 'generic/freebsd12', |
There was a problem hiding this comment.
In https://github.com/voxpupuli/beaker-hostgenerator/blob/master/lib/beaker-hostgenerator/hypervisor/vagrant.rb we already do similar conversions automatically so you don't have to maintain a manual mapping and you get it "for free" when FreeBSD 14 comes out..
There was a problem hiding this comment.
you're saying I can omit the vagrant => {} section?
There was a problem hiding this comment.
I'm not sure if it translates well, but if it doesn't then I'm suggesting to special case it in the vagrant hypervisor rather than overriding it here.
evgeni
force-pushed
the
freebsd
branch
2 times, most recently
from
fec05ae
to
6b91746
Compare
|
@ekohl seems to work well, also flipped to actually "generate" the entries too, as they are all identical |
No description provided.