Move more data into hypervisor specific classes #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #313 +/- ##
=========================================
+ Coverage 0.67% 0.74% +0.06%
=========================================
Files 15 15
Lines 1930 1756 -174
=========================================
Hits 13 13
+ Misses 1917 1743 -174
☔ View full report in Codecov by Sentry. |
ekohl
force-pushed
the
refactor-docker-hypervisor
branch
from
259c1ac
to
2e1711c
Compare
This creates helpers for the image and image commands. That makes it easier to expand it in the future without creating one monster method
bastelfreak
approved these changes
Jul 14, 2023
This uses the Hypervisor to add the commands if needed. It can use logic to reduce duplication.
ekohl
force-pushed
the
refactor-docker-hypervisor
branch
from
2e1711c
to
cd37f1a
Compare
This creates a generate_osinfo method for the simple cases where there's only an OS and platform tuple.
ekohl
force-pushed
the
refactor-docker-hypervisor
branch
from
cd37f1a
to
ce36db3
Compare
bastelfreak
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim is to reduce duplication in the data class. Making it shorter and easier to maintain.