Allow to disable debug output #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JFYI, main reason for this change is here: https://github.com/voxpupuli/voxpupuli-acceptance/blob/master/lib/voxpupuli/acceptance/spec_helper_acceptance.rb#L6 |
Currently if `BEAKER_debug` variable is set to anything then `beaker` is started with `--log-level debug` CLI option. This change allows to not enable debug logging if `BEAKER_debug` is set to `no`. That's useful when some upper layer sets this variable by default (as there is no way to unset it after).
bastelfreak
approved these changes
Dec 18, 2022
ekohl
approved these changes
Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if
BEAKER_debugvariable is set to anything thenbeakeris started with--log-level debugCLI option. This change allows to not enable debug logging ifBEAKER_debugis set tono. That's useful when some upper layer sets this variable by default (as there is no way to unset it after).