Ensure platform is Beaker::Platform in tests #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1855 +/- ##
==========================================
- Coverage 74.32% 74.30% -0.03%
==========================================
Files 79 79
Lines 4398 4398
==========================================
- Hits 3269 3268 -1
- Misses 1129 1130 +1 ☔ View full report in Codecov by Sentry. |
ekohl
force-pushed
the
ensure-correct-platform
branch
from
bc2c7f0 to
4a78cae
Compare
bastelfreak
approved these changes
Jul 24, 2024
Merged
This makes it easier to debug when they don't match.
Rather than updating it after the fact, this calls make_host once with the correct parameters.
The regular option parser guarantees this and it sort of works because Beaker::Platform can behave as a string (since it inherits from it). When you do want to use extended features, it fails. This enhances the helper to guarantee it's the correct class instance. Then there are many changes to the tests to ensure a valid platform is passed in.
ekohl
force-pushed
the
ensure-correct-platform
branch
from
4a78cae to
9d85e89
Compare
silug
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular option parser guarantees this and it sort of works because Beaker::Platform can behave as a string (since it inherits from it). When you do want to use extended features, it fails.
This enhances the helper to guarantee it's the correct class instance. Then there are many changes to the tests to ensure a valid platform is passed in.
Still incomplete and I wonder what we should do about the unix platform.I'm also tempted to drop some platforms instead.