Skip to content
This repository was archived by the owner on Feb 14, 2025. It is now read-only.

Commit

Permalink
(maint) Use all hostnames for Docker DNS_ALT_NAME
Browse files Browse the repository at this point in the history
 - Docker supplies the HOSTNAME value, which may be different from how
   host recognizes its hostname setting (short and fully qualified).

   While these values may be duplicated, that's OK b/c the ssl.sh
   script doesn't care if names are duplicated.

 - NOTE: hostname -s / hostname -f doesn't properly return under LCOW
   like it does on Linux, and always returns the short name
  • Loading branch information
Iristyle authored and Morgan Rhodes committed Oct 4, 2019
1 parent aebab42 commit 4687099
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion puppetdb/docker-entrypoint.d/30-configure-ssl.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
if [ ! -f "${SSLDIR}/certs/${CERTNAME}.pem" ] && [ "$USE_PUPPETSERVER" = true ]; then
set -e

DNS_ALT_NAMES="${HOSTNAME},${DNS_ALT_NAMES}" /ssl.sh "$CERTNAME"
DNS_ALT_NAMES="${HOSTNAME},$(hostname -s),$(hostname -f),${DNS_ALT_NAMES}" /ssl.sh "$CERTNAME"
fi

# cert files are present from Puppetserver OR have been user supplied
Expand Down

0 comments on commit 4687099

Please sign in to comment.