Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post latest release grouped rake tasks exits after running metadata_lint task. #70

Closed
shaheed121 opened this issue Jun 1, 2017 · 3 comments
Closed

Post latest release grouped rake tasks exits after running metadata_lint task. #70

shaheed121 opened this issue Jun 1, 2017 · 3 comments
Assignees
@domcleal

Comments

@shaheed121
Copy link

shaheed121 commented Jun 1, 2017 •
edited
Loading

After the latest update grouped rake tasks exit just after running metadata_lint task without any error. In the case below rake validation task exits just after running metadata_lint without running the syntax task.

desc 'Validate json hieradata'
JsonLint::RakeTask.new do |task|
  task.paths = ['data/**/*.json']
end

desc 'validation'
task :validation do
  Rake::Task[:jsonlint].invoke
  Rake::Task[:metadata_lint].invoke
  Rake::Task[:syntax].invoke
end
@shaheed121 shaheed121 changed the title Grouped rake tasks exits after running metadata_lint Post latest release grouped rake tasks exits after running metadata_lint task. Jun 1, 2017
@domcleal domcleal self-assigned this Jun 1, 2017
domcleal added a commit to domcleal/metadata-json-lint that referenced this issue Jun 1, 2017
@domcleal
Move exit() calls into CLI, allow rake tasks to keep executing
d28f7c0 
On success, no exit(0) call is made from a rake task, allowing execution
to continue to further tasks. exit() calls are now only made when used
in CLI mode.

Fixes voxpupuli#70
This was referenced Jun 1, 2017
Merged
Closed
@luyseyal
Copy link

luyseyal commented Jun 1, 2017

We also have this issue. Hoping you can prioritize a release. We've pinned to 1.1.0 in the meantime.

@davidmogar
Copy link
Member

davidmogar commented Jun 2, 2017 •
edited
Loading

When are you releasing a new version with this patch?

@domcleal
Copy link
Contributor

domcleal commented Jun 2, 2017

I've opened a PR to issue a release at #73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domcleal domcleal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@luyseyal @domcleal @davidmogar @shaheed121