Adds feature to check tags #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you fix the two rubocop failures please? Regarding the module line length, I think you could safely disable that for now until the module's refactored. |
|
@domcleal Done 👍 |
rnelson0
reviewed
Dec 5, 2016
| "source": "git://github.com/puppetlabs/puppet-postgresql.git", | ||
| "project_page": "https://github.com/puppetlabs/puppet-postgresql", | ||
| "issues_url": "https://github.com/puppetlabs/puppet-postgresql/issues", | ||
| "tags": "postgres", |
There was a problem hiding this comment.
I think there should be a corresponding test where it is in an array. There appear to be no other metadata.json files used for testing with the tags value, so it's not being tested elsewhere.
domcleal
requested changes
Dec 6, 2016
| test "tags_no_array" $FAILURE | ||
|
|
||
| # Run with tags in an array in metadata.json, expect SUCCESS | ||
| test "tags_no_array" $SUCCESS |
* Tags have to be in an array format, adds simple check for this * Bumped module length metric, as class is long right now, needs later refactor
juniorsysadmin
approved these changes
Dec 6, 2016
|
Thanks everyone 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44