Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit 1 if git push fails #125

Merged
merged 1 commit into from
Aug 1, 2017
Merged

Exit 1 if git push fails #125

merged 1 commit into from
Aug 1, 2017

Conversation

sean797
Copy link
Contributor

@sean797 sean797 commented Jul 28, 2017

@rnelson0
Copy link
Member

@sean797 we should have a test for the exit code as well, to prevent regressions, could you add one?

@sean797
Copy link
Contributor Author

sean797 commented Jul 31, 2017

Thanks @rnelson0 ! Updated and Travis seems happy 👍

@rnelson0 rnelson0 merged commit 1045aa8 into voxpupuli:master Aug 1, 2017
@rnelson0
Copy link
Member

rnelson0 commented Aug 1, 2017

@sean797 No, thank YOU! :D

@sean797 sean797 deleted the exit-code branch August 1, 2017 13:09
@cdenneen
Copy link
Contributor

@rnelson0 can we get a new release?

@sean797
Copy link
Contributor Author

sean797 commented Sep 19, 2017

@rnelson0 I too would appreciate a new release soon, is there plans to do one?

@rnelson0
Copy link
Member

See #128 please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sean797 @rnelson0 @cdenneen