Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes. #574

Closed
wants to merge 4 commits into from
Closed

Conversation

pillarsdotnet
Copy link
Contributor

@pillarsdotnet pillarsdotnet commented Jul 1, 2019

@@ -1,6 +1,6 @@
require: rubocop-rspec
AllCops:
TargetRubyVersion: 1.9
TargetRubyVersion: 2.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the past we had the question about whether we should stay compatible with older versions because they're also synced to older versions. Also unsure about JRuby compatibility levels. Anyone has something useful to say so we don't break anything?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the question is whether we need to stay syntax compatible with older rubies and I honestly don't know the answer. If we do, then we need to pin rubocop.

Copy link
Contributor Author

@pillarsdotnet pillarsdotnet Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl
I dropped the changes in .rubocop.yml.erb since they conflict with the rubocop version '~> 0.49.1' preferred by vox-pupuli .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jruby in puppetserver 5 is only ruby 1.9 compatible IIRC.

@pillarsdotnet
Copy link
Contributor Author

Breaking up into separate PR's per @alexjfisher .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants