add modules param to spec_helper_acceptance.rb.erb #837
Conversation
|
Another option would be a flag to remove |
jhoblitt
force-pushed
the
feature/configure_breaker_modules
branch
from
3f91a10
to
18827d7
Compare
|
Take #2 now with the ability to remove |
|
Grrr, rubocop is unhappy about the extra newline. Standby for take #3. |
jhoblitt
force-pushed
the
feature/configure_breaker_modules
branch
2 times, most recently
from
91721fc
to
fe6ab9f
Compare
| @@ -5,6 +5,8 @@ | |||
|
|
|||
| require 'voxpupuli/acceptance/spec_helper_acceptance' | |||
|
|
|||
| configure_beaker | |||
| <%- unless @configs['configure_beaker'].nil? -%> | |||
There was a problem hiding this comment.
thinking about it again... if it's set to :fixtures we could automatically add task :beaker => "spec_prep" to the rakefile? But that would then require puppetlabs_spec_helper 🤔
There was a problem hiding this comment.
Yes, the gem would need to be added. Here's a PR I'm currently working on that has .sync.yml changes (rewritten by psych) and adds ./rakelib/beaker.rake. https://github.com/lsst-it/puppet-ccs_software/pull/39/files
There was a problem hiding this comment.
That PR is also a good example of the pain of .fixtures.yml not having any dep resolution. I don't understand why Puppetfile never became a thing for test fixtures...
There was a problem hiding this comment.
Probably because r10k doesn't do dependency resolution either. Does Puppetfile support symlinks?
There was a problem hiding this comment.
thinking about it again... if it's set to
:fixtureswe could automatically addtask :beaker => "spec_prep"to the rakefile? But that would then require puppetlabs_spec_helper thinking
Perhaps this bit would be useful in Rakefile: https://github.com/theforeman/foreman-installer-modulesync/blob/5bff8e9a2800ea6e0928aaaa0c2778c60d426bc1/moduleroot/Rakefile.erb#L21-L22
jhoblitt
force-pushed
the
feature/configure_breaker_modules
branch
from
fe6ab9f
to
a4f9849
Compare
No description provided.