Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct variable name for changelog github token #890

Merged

Conversation

h-haaks
Copy link
Contributor

@h-haaks h-haaks commented Apr 24, 2024

Following the existing doc led to:

Warning: No token provided (-t option) and variable $CHANGELOG_GITHUB_TOKEN was not found. This script can make only 50 requests to GitHub API per hour without a token!

@h-haaks h-haaks force-pushed the fix-release-docs-bug branch 2 times, most recently from b350fa9 to 098f981 Compare April 24, 2024 23:06
@h-haaks
Copy link
Contributor Author

h-haaks commented Apr 24, 2024

Hmm struggling with signing the commit ...

@@ -183,5 +183,4 @@ the `modulesync_config` repository.
## Do a new release

* Update the version in `moduleroot/.msync.yml.erb`
* export `GITHUB_CHANGELOG_TOKEN='*your token*'`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh, that should have been CHANGELOG_GITHUB_TOKEN, the rest of it is still ok

@bastelfreak bastelfreak merged commit 51d2580 into voxpupuli:master Apr 25, 2024
4 checks passed
@h-haaks h-haaks deleted the fix-release-docs-bug branch April 25, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants