New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lint rake task for lint pre-commit check #898

Merged

wyardley merged 1 commit into voxpupuli:master from wyardley:wyardley/rake_lint

May 21, 2024

Contributor

wyardley commented May 21, 2024

The existing bundle exec puppet-lint is prone to erroring with autoload errors that are allowed under our normal structure / lint rules.

Runs puppet-lint on modified files only..................[PuppetLint] FAILED
Errors on lines you didn't modify:
/Users/wby/git/puppet-rabbitmq/manifests/init.pp:349:7:ERROR: rabbitmq not in autoload module layout (autoloader_layout)
Warnings on lines you didn't modify:

This appears to work from some local testing, and AFAICT still runs only on modified files.


Use lint rake task for lint pre-commit check

6b71060

kenyon reviewed

View reviewed changes

Member

kenyon left a comment

WFM locally too.

kenyon approved these changes

View reviewed changes

wyardley merged commit d901709 into voxpupuli:master

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment