Move mock_with to a single RSpec.configure block #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously mock_with needed to be set before loading puppetlabs_spec_helper to avoid using legacy compatibility initialization. Since version 5 this is no longer needed[1]. voxpupuli-test already pulls in this version for some time, so no dependency bump is needed. [1]: puppetlabs/puppetlabs_spec_helper@493f0cb
bastelfreak
added a commit
to bastelfreak/modulesync_config
that referenced
this pull request
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
mock_withneeded to be set before loadingpuppetlabs_spec_helperto avoid using legacy compatibility initialization. Since version 5 this is no longer needed. voxpupuli-test already pulls in this version for some time, so no dependency bump is needed.