rspec: Remove Puppet::Util::Storage mock #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lollipopman
force-pushed
the
puppet-util-storage
branch
from
dbd4e3a
to
dedc90c
Compare
In attempting to upgrade bodgit/puppet-postfix's[^1] dependency on this
module, I received the following error:
Failure/Error: allow(Puppet::Util::Storage).to receive(:store)
The use of doubles or partial doubles from rspec-mocks outside
of the per-test lifecycle is not supported.
This appears to be the result of the change in
637108e to use a mock rather than a
stub. However, it is not clear to me why Puppet::Util::Storage needs to
be mocked, as all tests still pass in this module and puppet-postfix
without it, so remove.
[1]: https://github.com/bodgit/puppet-postfix
lollipopman
force-pushed
the
puppet-util-storage
branch
from
dedc90c
to
aa427ad
Compare
smortex
approved these changes
Dec 16, 2022
|
thanks @smortex! |
wmfgerrit
pushed a commit
to wikimedia/operations-puppet
that referenced
this pull request
Dec 21, 2022
This commit adds a vendored module: https://github.com/bodgit/puppet-postfix Along with its dependencies. This module and its dependencies are licensed under the Apache-2.0 license. Three additional patches on top of upstream have been added, which are open pull requests: 1. Add Debian Bullseye(11) support 2. Fix support for /etc/aliases 3. Debian: don't install Augeas lens for unix-dgram This module has been used to build a testing configuration for replacing our existing use of Exim. Thus far it seems to be a well built module and is worth vendoring based on my review of the code. Dependencies: 1. `bodgit/bodgitlib`: Unneeded currently, used for ldap, memcache, mysql, & pgsql lookups, we could always add it if we started using those postfix lookup types. 2. `herculesteam/augeasproviders_core`: Alternative Augeas provider module which is now under Voxpupuli, this will be updated to their version once a new version is cut which includes my recent pull request, <voxpupuli/puppet-augeasproviders_core#42> 3. `camptocamp/augeas`: Unneeded, as we already have the updated postfix lens Bug: T325396 Change-Id: I1f50481e6f06ba802c90c7b94057eacb71c10582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In attempting to upgrade https://github.com/bodgit/puppet-postfix's dependency on this
module, I received the following error:
This appears to be the result of the change in
637108e to use a mock rather than a stub. However, it is not clear to me why Puppet::Util::Storage needs to
be mocked, as all tests still pass in this module and puppet-postfix
without it, so remove.