Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Global EFI support #28

Merged
merged 4 commits into from
Aug 29, 2017

Conversation

trevor-vaughan
Copy link
Contributor

  • Updated EFI support
  • Added tests for Puppet 5 and Ruby 2.4.0
  • Added compatiblity with CentOS
  • Restricted RHEL and CentOS versions to those that can be tested
  • Eliminated old Ruby versions from the tests since they fundamentally
    break

Closes #27

* Updated EFI support
* Added tests for Puppet 5 and Ruby 2.4.0
* Added compatiblity with CentOS
* Restricted RHEL and CentOS versions to those that can be tested
* Eliminated old Ruby versions from the tests since they fundamentally
  break

Closes voxpupuli#27
@coveralls
Copy link

coveralls commented Aug 15, 2017

Coverage Status

Coverage decreased (-0.5%) to 95.906% when pulling 78d8269 on trevor-vaughan:global_efi_support into 80db0af on hercules-team:master.

* Don't loop through all EFI files
* Make the Facter call safe
@coveralls
Copy link

coveralls commented Aug 29, 2017

Coverage Status

Coverage decreased (-1.0%) to 95.402% when pulling d4a5019 on trevor-vaughan:global_efi_support into 80db0af on hercules-team:master.

Copy link

@nick-markowski nick-markowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good to me

CHANGELOG.md Outdated
- Added code to fix the EFI stack on Linux hosts
- Restricted the RHEL and CentOS support to only what can be tested
- Pinned supported puppet versions between 4.7.2 and 5.0.0
- This is the oldes Puppet, Inc. supported version and there are currently

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oldest*

@trevor-vaughan trevor-vaughan merged commit 5e2d464 into voxpupuli:master Aug 29, 2017
@coveralls
Copy link

coveralls commented Aug 29, 2017

Coverage Status

Coverage decreased (-1.0%) to 95.402% when pulling 79ba8fe on trevor-vaughan:global_efi_support into 80db0af on hercules-team:master.

@coveralls
Copy link

coveralls commented Aug 29, 2017

Coverage Status

Coverage decreased (-1.0%) to 95.402% when pulling ec362b3 on trevor-vaughan:global_efi_support into 80db0af on hercules-team:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants