Call grub2-mkconfig on all targets #57
Conversation
Currently grub2-mkconfig is called on the first file
that exists from.
```
"/etc/grub2-efi.cfg",
"/boot/efi/EFI/#{os_name.downcase}/grub.cfg",
"/boot/grub2/grub.cfg",
"/boot/grub/grub.cfg"
```
So on a CentOS 7 system `grub2-efi.cfg` is generated only
from `/etc/default/grub`.
With an EFI system configured for bios boot the
`/boot/grub2/grub.cfg` is the important one so
`kernel_parameter` updates are not applied.
Taking inspiration from [new-kernel-pkg](https://github.com/rhboot/grubby/blob/master/new-kernel-pkg)
to see what happens on kernel upgrade `grubby` is called for each of
these files that exists so emulating this logic make sense.
Fixes voxpupuli#4
|
If you can give me a hint at what is missing for the coveralls happy to have ago. |
|
@traylenator Don't worry about minor coveralls issues. I'll try to take a look at this today. It's been a pain trying to get this right across the board. |
| @@ -175,14 +175,15 @@ def flush | |||
| if FileTest.file?(c) || ( FileTest.symlink?(c) && | |||
| FileTest.directory?(File.dirname(File.absolute_path(File.readlink(c)))) ) | |||
|
|
|||
| cfg = c | |||
| break | |||
| cfg.push(c) | |||
There was a problem hiding this comment.
More common syntax
| cfg.push(c) | |
| cfg << c |
There was a problem hiding this comment.
Also, this can probably be refactored as #select instead of #each to avoid the push.
There was a problem hiding this comment.
I can't get the perl out of me.
There was a problem hiding this comment.
select is not immediately obvious due the super call.
|
For interest some back ground that led to this: https://techblog.web.cern.ch/techblog/post/bios_uefi_cloud_image/ |
|
I'm labeling this as backwards-incompatible as this has the potential to break the boot config when this module starts doing what it was supposed to be doing. |
Currently grub2-mkconfig is called on the first file
that exists from.
So on a CentOS 7 system
grub2-efi.cfgis generated onlyfrom
/etc/default/grub.With an EFI system configured for bios boot the
/boot/grub2/grub.cfgis the important one sokernel_parameterupdates are not applied.Taking inspiration from new-kernel-pkg
to see what happens on kernel upgrade
grubbyis called for each ofthese files that exists so emulating this logic make sense.
Fixes #4