Fix handling for bare-string mapcontents #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data type for the 'macontents' parameters of autofs::mount and autofs::map permit both arrays and bare strings, and the documentation is consistent with that, but catalog building failed when a bare string is assigned to one of these parameters. The bug was in the templates; these are updated to handle the situation, and a unit test is added to verify that it works.
juniorsysadmin
approved these changes
Mar 24, 2018
|
I would have preferred array or string, not allowing both in #95 but that is a breaking change for another day. |
bastelfreak
changed the title
|
Thanks for the patch @jcbollinger ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data type for the 'macontents' parameters of autofs::mount and
autofs::map permits both arrays and bare strings, and the documentation
is consistent with that, but catalog building failed when a bare string
is assigned to one of these parameters. The bug was in the templates;
these are updated to handle the situation, and a unit test is added to
verify that it works.
Closes #108