Specify default for order parameter on auto::mount #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhollinger
requested changes
Jun 15, 2017
manifests/mount.pp
Outdated
| @@ -31,6 +31,7 @@ | |||
| # path using filenames ending in the ".autofs" extension. | |||
| # @param options Options for the autofs mount point within in the auto.master. | |||
| # @param order Order in which entries will appear in the autofs master file. | |||
| # Defaults to 1. | |||
There was a problem hiding this comment.
Default doesn't need to be specified in puppet strings @param tags.
There was a problem hiding this comment.
Learnt - thanks.
traylenator
force-pushed
the
defaultorder
branch
from
647a30f to
038bd48
Compare
|
@traylenator can you rebase? |
The `order` parameter to `auto::mount`
```puppet
auto::mount{'home':
mount => '/home',
mapfile => '/etc/auto.home',
order => 3,
...
}
```
currently must be specified.
Especially since in the vast majority of cases the order of the lines
in `/etc/auto.master` is irrelevent a default this value can be specified.
Motification, less mandatory options always good.
traylenator
force-pushed
the
defaultorder
branch
from
038bd48 to
e5f3f46
Compare
dhollinger
approved these changes
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
orderparameter toauto::mountcurrently must be specified.
Especially since in the vast majority of cases the order of the lines
in
/etc/auto.masteris irrelevent a default this value can be specified.Motification, less mandatory options always good.