Add Puppet 5 compatibility #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included autofs main class in define to ensure that the package and service dependencies and notifications are met.
dhollinger
requested review from
bastelfreak and
traylenator
and removed request for
traylenator
bastelfreak
reviewed
Jul 2, 2017
manifests/mount.pp
Outdated
| @@ -62,6 +62,7 @@ | |||
| Array $mapcontents = [], | |||
| Boolean $replace = true | |||
| ) { | |||
| include 'autofs' | |||
There was a problem hiding this comment.
we need include ::autofs or contain ::autofs here.
There was a problem hiding this comment.
I don't think a class can be contained multiple times?
dhollinger
force-pushed
the
puppet5-compat
branch
from
db78434 to
1296143
Compare
Updated the define tests for Puppet 5, integrated puppet_rspec_facts into the define tests, and ensured that unit coverage tested all resources and defined resources at least once
dhollinger
force-pushed
the
puppet5-compat
branch
from
1296143 to
a52f900
Compare
bastelfreak
approved these changes
Jul 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autofsclass in mount define to ensurepackageandserviceresources are available.closes #73