Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sensitive passwords #190

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions REFERENCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ Default value: `[]`

##### <a name="-bacula--client--password"></a>`password`

Data type: `String`
Data type: `Variant[String,Sensitive[String]]`

A password to use for communication with this File Daemon

Expand Down Expand Up @@ -557,7 +557,7 @@ Default value: `'bacula'`

##### <a name="-bacula--director--db_pw"></a>`db_pw`

Data type: `String`
Data type: `Variant[String,Sensitive[String]]`

The database user's password

Expand Down Expand Up @@ -654,7 +654,7 @@ Default value: `true`

##### <a name="-bacula--director--password"></a>`password`

Data type: `String`
Data type: `Variant[String,Sensitive[String]]`

password to connect to the director

Expand Down Expand Up @@ -882,7 +882,7 @@ Default value: `'File'`

##### <a name="-bacula--storage--password"></a>`password`

Data type: `String`
Data type: `Variant[String,Sensitive[String]]`

Specifies the password that must be supplied by the named Director

Expand Down Expand Up @@ -977,7 +977,7 @@ The port of the Bacula File server daemon

##### <a name="-bacula--director--client--password"></a>`password`

Data type: `String`
Data type: `Variant[String,Sensitive[String]]`

The password to be used when establishing a connection with the File services

Expand Down Expand Up @@ -1301,7 +1301,7 @@ Default value: `9103`

##### <a name="-bacula--director--storage--password"></a>`password`

Data type: `String`
Data type: `Variant[String,Sensitive[String]]`

Bacula director configuration for Storage option 'Password'

Expand Down
2 changes: 1 addition & 1 deletion manifests/client.pp
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
Optional[String] $default_pool_diff,
Integer $port = 9102,
Array[String[1]] $listen_address = [],
String $password = 'secret',
Variant[String,Sensitive[String]] $password = 'secret',
Integer $max_concurrent_jobs = 2,
String $director_name = $bacula::director_name,
Bacula::Yesno $autoprune = true,
Expand Down
4 changes: 2 additions & 2 deletions manifests/director.pp
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
Bacula::Yesno $manage_db = true,
String $conf_dir = $bacula::conf_dir,
String $db_name = 'bacula',
String $db_pw = 'notverysecret',
Variant[String,Sensitive[String]] $db_pw = 'notverysecret',
String $db_user = 'bacula',
Optional[String] $db_address = undef,
Optional[String] $db_port = undef,
Expand All @@ -54,7 +54,7 @@
Array[String[1]] $listen_address = [],
Integer $max_concurrent_jobs = 20,
Boolean $manage_defaults = true,
String $password = 'secret',
Variant[String,Sensitive[String]] $password = 'secret',
Integer $port = 9101,
String $rundir = $bacula::rundir,
String $storage_name = $bacula::storage_name,
Expand Down
2 changes: 1 addition & 1 deletion manifests/director/client.pp
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
define bacula::director::client (
String $address,
Variant[String,Integer] $port, # FIXME: Remove String
String $password,
Variant[String,Sensitive[String]] $password,
Bacula::Time $file_retention,
Bacula::Time $job_retention,
Bacula::Yesno $autoprune,
Expand Down
2 changes: 1 addition & 1 deletion manifests/director/storage.pp
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
define bacula::director::storage (
String $address = $name,
Integer $port = 9103,
String $password = 'secret',
Variant[String,Sensitive[String]] $password = 'secret',
String $device_name = "${facts['networking']['fqdn']}-device",
String $media_type = 'File',
Integer $maxconcurjobs = 1,
Expand Down
2 changes: 1 addition & 1 deletion manifests/storage.pp
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
Array[String[1]] $listen_address = [],
Integer $maxconcurjobs = 5,
String $media_type = 'File',
String $password = 'secret',
Variant[String,Sensitive[String]] $password = 'secret',
Integer $port = 9103,
String $rundir = $bacula::rundir,
String $storage = $trusted['certname'], # storage here is not storage_name
Expand Down