Support distrusting ca's on Debian; Changed ca_cert::ca parameter names and meaning #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-haaks
commented
Jun 5, 2024
| @@ -2,31 +2,32 @@ | |||
|
|
|||
| case host_inventory['facter']['os']['family'] | |||
| when 'Debian' | |||
| trusted_ca_file_remote = '/usr/local/share/ca-certificates/Globalsign_Org_Intermediate.crt' | |||
| absent_ca_file_remote = '/etc/pki/ca-trust/source/blacklist/CACert.crt' | |||
| trusted_ca_file_remote = '/usr/local/share/ca-certificates/DigiCert_G5_TLS_ECC_SHA384_2021_CA1.crt' | |||
There was a problem hiding this comment.
I switch from Globalsign to Digicert certificate here because globalsign certificates are only available for download i DER format.
h-haaks
commented
Jun 5, 2024
spec/acceptance/ca_cert_ca_spec.rb
Outdated
| trusted_ca_file_text = '/etc/pki/ca-trust/source/anchors/InCommon.crt' | ||
| untrusted_ca_file_remote = '/etc/pki/ca-trust/source/blacklist/DigiCert_Global_Root_G3.crt' |
There was a problem hiding this comment.
Switched to a ca that actually exists in the trusted list on all distros.
|
Seems to be some issues with 'distrust' on el9 surfacing because I've added integration tests that verifies the generated trust list. |
h-haaks
force-pushed
the
support-distrust-for-debian
branch
2 times, most recently
from
fae369e to
124031e
Compare
h-haaks
changed the title
h-haaks
changed the title
h-haaks
force-pushed
the
support-distrust-for-debian
branch
2 times, most recently
from
578c31a to
555e05b
Compare
kenyon
reviewed
Jun 5, 2024
manifests/init.pp
Outdated
| @@ -34,6 +34,10 @@ | |||
| # Absolute directory path to the folder containing distrusted certificates. | |||
| # Default provided by Hiera for supported Operating Systems. | |||
| # | |||
| # @param ca_certificates_conf | |||
| # Some distros uses a configuration file to mark distrusted certificates. | |||
There was a problem hiding this comment.
Suggested change
| # Some distros uses a configuration file to mark distrusted certificates. | |
| # Some distros use a configuration file to mark distrusted certificates. |
kenyon
approved these changes
Jun 5, 2024
h-haaks
force-pushed
the
support-distrust-for-debian
branch
from
555e05b to
6dd5a4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Rework of ca_cert::ca to support trusting and distrusting ca's provided by the ca-certificates package on Debian.
Also makes it possible to move from distrusted to trusted again on other distros ( ensure absent from
distrusted_cert_dir)To support this I have redefined the meaning of ca_cert::ca::ensure a bit
trusted_cert_dirdistrusted_cert_dirog Debian'sca_certificates_confca_cert::ca::ca_textis renamed toca_cert::ca::contentand used directly asfile::contentca_cert::ca::sourceis now used directly asarchive::sourceca_cert::ca::verify_https_certparameter is renamed toca_cert::ca::allow_insecure_sourceto better align witharchive::allow_insecureThis Pull Request (PR) fixes the following issues
Fixes #96