Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add write_graphite options introduced in collectd 5.7.0 #1014

Merged
merged 4 commits into from
Feb 6, 2023
Merged

Add write_graphite options introduced in collectd 5.7.0 #1014

merged 4 commits into from
Feb 6, 2023

Conversation

gerases
Copy link

@gerases gerases commented Jan 29, 2023

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@gerases
Copy link
Author

gerases commented Jan 29, 2023

I'm still working on this branch, it's work in progress

@gerases gerases force-pushed the modify-write-graphite-plugin branch from 691efce to 5a13a85 Compare January 30, 2023 00:04
@gerases gerases force-pushed the modify-write-graphite-plugin branch from 5a13a85 to 34d072c Compare January 30, 2023 00:05
@gerases gerases force-pushed the modify-write-graphite-plugin branch from 34d072c to 0ea0410 Compare January 30, 2023 00:19
@smortex
Copy link
Member

smortex commented Jan 30, 2023

The PR title says 5.8 but the code says 5.7…

I'm still working on this branch, it's work in progress

Is it still the case? FYI, you can make this PR a draft while you are working on it (top of the menu on right), so that maintainers know that it is being worked on an then turn it back to the "ready for rewiew" state when you are ready 😉

@bastelfreak bastelfreak added the enhancement New feature or request label Jan 30, 2023
@gerases gerases changed the title Add write_graphite options introduced in collectd 5.8.0 Add write_graphite options introduced in collectd 5.7.0 Jan 30, 2023
@gerases gerases marked this pull request as draft January 30, 2023 15:21
@gerases
Copy link
Author

gerases commented Jan 30, 2023

Thanks for the tip on coverting the PR to a "draft". About 5.8, yes, originally I thought it was 5.8 but after more research I realized it was 5.7 as far as the collectd github code is concerned. But it's possible the RPM where it was first introduced was 5.8. Still researching that part.

@gerases gerases marked this pull request as ready for review January 30, 2023 16:23
@gerases gerases marked this pull request as draft January 30, 2023 16:23
@gerases gerases marked this pull request as ready for review January 30, 2023 16:34
smortex
smortex approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerases
Copy link
Author

gerases commented Feb 6, 2023

Hi @smortex, what does the ETA for merging this look like? Just curious.

@smortex
Copy link
Member

smortex commented Feb 6, 2023

I like to let other people double-check areas I am not familiar with, but after a week I think we can safely merge it.

@smortex smortex merged commit 8fa5ab6 into voxpupuli:master Feb 6, 2023
@gerases
Copy link
Author

gerases commented Feb 6, 2023

Sounds good, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gerases @smortex @bastelfreak