Add modbus plugin #994
Open
Add modbus plugin #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruleant
force-pushed
the
modbus
branch
3 times, most recently
from
e0df3f1 to
3411ed0
Compare
This commit implements a modbus plugin. It installs required packages and generates configuration for hosts and datasets.
traylenator
requested changes
Sep 2, 2022
| @@ -0,0 +1,42 @@ | |||
| <% if @data or @hosts -%> | |||
There was a problem hiding this comment.
If adding a new template could it be written in EPP?
| @@ -0,0 +1,2 @@ | |||
| # | |||
| type Collectd::Modbus::Data = Struct[{Optional['instance'] => String, NotUndef['type'] => String[1], NotUndef['register_base'] => Numeric, NotUndef['register_type'] => String[1]}] | |||
There was a problem hiding this comment.
Could we add some tests for this and the other types.
e.g. like https://github.com/voxpupuli/puppet-systemd/tree/master/spec/type_aliases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR implements a modbus plugin for collectd.
It allows to specify hosts and data sets.