moving end statement to allow values from java_opts to be applied to … #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…setenv.sh file. These values are needed if you are running confluence behind proxies and to allow the synchrony functionality.
pillarsdotnet
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…setenv.sh file. These values are needed if you are running confluence behind proxies and to allow the synchrony functionality.
Pull Request (PR) description
The PR fixes the passing of java_opt values in order to populate things like proxy servers or values for supporting synchrony.
If these values are not passed, things like the Market place will NOT work because the application is not aware of the proxy it should be sending traffic to.
Also for synchrony to work, you need to pass the following values:
JAVA_OPTS="-Dsynchrony.proxy.enabled=trueThese values should not be bound to the version of confluence.
These values are currently in use in about 3 different Confluence installations of different versions of the application.
This Pull Request (PR) fixes the following issues
No specific issues (reported) but it does allow the following to work:
Atlassian market place
Synchrony