Add tomcat_redirect_port variable to customise redirectPort in server.xml #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techtino
force-pushed
the
master
branch
3 times, most recently
from
2439214
to
d5dcc2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR allows a user to define a port to redirect to on the default connector using a variable, similarly to tomcat_port. In my case I needed to use manage_server_xml in template mode so I could define an additional connector, which doesn't work with tomcat_extras so I couldn't define it there.
Arguably everything about the default connector should be customisable in server xml template mode, so we could add those if needed also.
Also, somewhat unrelated but tomcat_additional_connectors does not work with the augeaus mode, unless I'm missing something.
This Pull Request (PR) fixes the following issues
N/A