Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable to configure maxHttpHeaderSize attribute #221

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

danifr
Copy link
Member

@danifr danifr commented Oct 20, 2022

Pull Request (PR) description

Add variable to be able to configure tomcat's maxHttpHeaderSize attribute.

Default is set to 8192 (from https://tomcat.apache.org/tomcat-9.0-doc/config/http.html maxHttpHeaderSize: If not specified, this attribute is set to 8192 (8 KB).)

@danifr
Copy link
Member Author

danifr commented Oct 27, 2022

Hi @smortex, sorry to bother you with this. Do you think you can review my PR? Thanks

@danifr
Copy link
Member Author

danifr commented Dec 21, 2022

Hello @bastelfreak, can you please check this PR when you have some time? Thanks.

@danifr danifr self-assigned this Feb 15, 2023
@danifr
Copy link
Member Author

danifr commented Feb 16, 2023

I will merge this change if no one objects to

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Sorry for missing the mention, I guess I had to sort out too many notifications from GitHub when I came back from holidays 😒…

I think I found a typo, can you double-check it?

manifests/config.pp Outdated Show resolved Hide resolved
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danifr danifr merged commit 543ea37 into voxpupuli:master Feb 22, 2023
@danifr danifr deleted the header_size branch February 22, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants