-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix modulesync; Drop EoL CentOS 6 support #223
Fix modulesync; Drop EoL CentOS 6 support #223
Conversation
0c502b4
to
5537bd4
Compare
metadata.json
Outdated
@@ -11,15 +11,15 @@ | |||
"dependencies": [ | |||
{ | |||
"name": "puppet/archive", | |||
"version_requirement": ">= 1.0.0 < 6.0.0" | |||
"version_requirement": ">= 1.0.0 < 5.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
puppet/mysql_java_connector does not support 5.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll start working on modulesync issues in puppet/mysql_java_connector so that we can get this inline as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for all the work. I made a new release for the mysql_java_connector.
metadata.json
Outdated
}, | ||
{ | ||
"name": "puppet/mysql_java_connector", | ||
"version_requirement": ">= 3.0.2 < 5.0.0" | ||
}, | ||
{ | ||
"name": "puppetlabs/stdlib", | ||
"version_requirement": ">= 4.13.1 < 9.0.0" | ||
"version_requirement": ">= 4.13.1 < 7.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
puppet/mysql_java_connector does not support puppetlabs/stdlib >= 7.x
file { $jh: | ||
ensure => directory, | ||
} -> | ||
archive { 'jdk11': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch to Archive and zulu jdk8
download_url => #{download_url}, | ||
javahome => $jh, | ||
version => '5.5.6', | ||
jvm_type => 'oracle-jdk-1.8', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added jvm_type because jdk11 is the default but confluence 5.5.6 does not run on java11 ...
@bastelfreak is this ready for merge now? |
@@ -32,14 +32,12 @@ | |||
{ | |||
"operatingsystem": "RedHat", | |||
"operatingsystemrelease": [ | |||
"6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acceptance tests failed on CentOS 6. Removed support since it's EOL
Fixes #211 |
I guess it also fixes #202 |
5537bd4
to
2a4bfcc
Compare
thanks for all the work! |
Pull Request (PR) description