Validate command for config files doesn't work

[joshuaspence]

With Consul 1.0, the change from #372 doesn't seem to work because the temporary config file doesn't end with .json.

       	Error: Execution of '/usr/local/bin/consul validate /etc/consul/config.json20171025-5833-1sgyj3d > /dev/null' returned 1: Config validation failed: Missing or invalid file extension for "/etc/consul/config.json20171025-5833-1sgyj3d". Please use ".json" or ".hcl".
       	Error: /Stage[main]/Consul::Config/File[consul config.json]/ensure: change from absent to present failed: Execution of '/usr/local/bin/consul validate /etc/consul/config.json20171025-5833-1sgyj3d > /dev/null' returned 1: Config validation failed: Missing or invalid file extension for "/etc/consul/config.json20171025-5833-1sgyj3d". Please use ".json" or ".hcl".

[joshuaspence]

It looks like Consul version 1.0.1 addresses this problem, see hashicorp/consul#3620.

[khdevel]

It is almost fixed... the only thing is missing is that the symbolic link still exist so puppet has problem during some second config.json update

Error: Execution of '/usr/local/bin/consul validate $(ln -s /etc/consul/config.json20171114-19498-11xf5vn /tmp/consul-config.json && echo "/tmp/consul-config.json") > /dev/null' returned 1: ln: failed to create symbolic link '/tmp/consul-config.json': File exists

$ ll /tmp/consul-config.json
lrwxrwxrwx. 1 root root 43 Nov 14 07:59 /tmp/consul-config.json -> /etc/consul/config.json20171114-2182-v34nfw

ln -sf should help...

[solarkennedy]

I just merged in a PR that does ln -sf

[joshuaspence]

The symbolic link approach feels so dirty... Why not just use -config-format=json?