More rpc port support for debian/upstart

[solarkennedy]

Related to #173

I wish we didn't have so many init scripts to maintain :(

[aj-jester]

I tested it on Ubuntu and it works 👍

One trivial suggestion I would make is adding a test when the rpc_addr == client_addr because of this https://github.com/solarkennedy/puppet-consul/blob/master/manifests/init.pp#L133

So something like:

context "When rpc_addr defaults to client_addr on sysv" do
    let (:params) {{
      :init_style => 'sysv',
      :config_hash => {
        'client_addr' => '192.168.34.56',
      }
    }}
    it { should contain_class('consul').with_init_style('sysv') }
    it {
      should contain_file('/etc/init.d/consul').
        with_content(/-rpc-addr=192.168.34.56:8400/)
    }
  end

🚄 LGTM

[aj-jester]

@solarkennedy Sorry this is my fault, I should've asked for this test to be added in the other PR as well, I didn't think about it then, so yah no big deal if we don't want to add.

[solarkennedy]

Added! Thanks.