Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consul Version Fact #209

Merged
merged 13 commits into from
Feb 2, 2016
Merged

Consul Version Fact #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
533f590
Merge pull request #2 from solarkennedy/master
robrankin Dec 17, 2015
9ddb175
Adding Consul Version Puppet fact
robrankin Dec 17, 2015
d2dcb9d
Fixing PS Windows Fact
robrankin Dec 17, 2015
bfd9b77
Rewrite as ruby
robrankin Dec 17, 2015
ee01560
Test for consul_version fact
robrankin Dec 17, 2015
d578f59
Test without consul installed on linux
robrankin Dec 17, 2015
6f189af
Add Windows test
robrankin Dec 17, 2015
e5c9746
Merge pull request #3 from solarkennedy/master
robrankin Dec 17, 2015
ae3bdd9
Remove Windows support from fact for now
robrankin Dec 18, 2015
b01d49e
Merge pull request #4 from solarkennedy/master
robrankin Feb 2, 2016
f848024
Specify value to test
robrankin Feb 2, 2016
acb20f8
Quiet any error output for nodes that dont have Consul installed
robrankin Feb 2, 2016
dfbcf8f
Corecting the test would be a good idea as well
robrankin Feb 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/facter/consul_version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# consul_version.rb

Facter.add(:consul_version) do
confine :kernel => 'Linux'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for using confine

setcode do
version = Facter::Util::Resolution.exec('consul --version 2> /dev/null')
version = version.lines.first.split[1].tr('v','')
version
end
end
24 changes: 24 additions & 0 deletions spec/unit/facter/consul_version_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
require "spec_helper"

describe Facter::Util::Fact do
before {
Facter.clear
}

describe "consul_version" do

context 'Returns consul version on Linux'
it do
consul_version_output = <<-EOS
Consul v0.6.0
Consul Protocol: 3 (Understands back to: 1)
EOS
allow(Facter.fact(:kernel)).to receive(:value).and_return("Linux")
allow(Facter::Util::Resolution).to receive(:exec).with('consul --version 2> /dev/null').
and_return(consul_version_output)
expect(Facter.fact(:consul_version).value).to match('0.6.0')
end

end

end