Puppet 6 support #444
Merged
Puppet 6 support #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes als sure that the pretty and not pretty case is tested for the simple cases. Also switched from the deprecated "subject.call" to subject.execute for the tests.
bastelfreak
reviewed
Oct 16, 2018
| @@ -11,7 +11,7 @@ | |||
| "requirements": [ | |||
| { | |||
| "name": "puppet", | |||
| "version_requirement": ">= 4.7.1 < 6.0.0" | |||
| "version_requirement": ">= 4.7.1 < 7.0.0" | |||
There was a problem hiding this comment.
do the new functions actually work with puppet 4.7.1 or do they require puppet5/4.10?
There was a problem hiding this comment.
In the docs it states that the legacy API should only be used for puppet 3.x compatibility, so I assumed that puppet 4.x should be supported. The docs for 4.9 mention both APIs so at least 4.9 should be supported (these pages do not exist for 4.8 and 4.7 unfortunately).
|
Thanks. I will mark this as |
Closed
spuder
pushed a commit
to spuder/puppet-consul
that referenced
this pull request
Feb 25, 2020
Puppet 6 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the consul module run under puppet 6. It converts the functions from the legacy puppet 3.x API to the new puppet function API. It also adds unit tests to the travis jobs for puppet6 to ensure future compatibility.