PDK convert, merged changes, pdk validate linter cleanup of pp files

[dan-wittenberg]

No description provided.

[bastelfreak]

Was that actually suggested by PDK? Leading :: is deprecated since Puppet 4.

[bastelfreak]

please add the newline at the end of the file.

[bastelfreak]

Hi @dan-wittenberg, thanks for all the work. Can you please document in te README.md how you used the pdk and how syncs in the future can be made?

[dan-wittenberg]

This was basic pdk convert, which only happens once, in the future pdk validate will simply tell you if it wants you to update something, so shouldn't be anything unusual after the first time.

…

On Thu, Jan 17, 2019 at 6:36 PM Tim Meusel ***@***.***> wrote: Hi @dan-wittenberg <https://github.com/dan-wittenberg>, thanks for all the work. Can you please document in te README.md how you used the pdk and how syncs in the future can be made? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#463 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANCBg-tYPcFfRmFxr-7uh0mmON2AGXXcks5vERcogaJpZM4aDFC7> .

-- *Daniel Wittenberg* *|* *Sr. Technical Architect* *|* *AHEAD* Work: 312.508.4996 | Mobile: 319.329.9776 | Fax: 312.924.5076 dan.wittenberg@ThinkAHEAD.com | ThinkAHEAD.com <http://info.thinkahead.com/e1t/c/*W6xgnfb3P660yN6FC2m6RB8ng0/*VZbrYd83jBHmW8yYcRc7tsC9Q0/5/f18dQhb0S5fw8XJ8hgW7-KP3h2qwv1yN32Gdlh5YWcwMf59TdXD6prW39Dr-N8pCDJGVYwxWD50wxKSW1wSwgX6PZxrZW1nrCGw96zRPSW6bT6L38RRjRDW5Ckvpl6vYDb4W7v70tS4RYYVxW3s1XjF51G0BFN4-0Bs5YSX-5W7m_B1R5c8d-SW377W4T2y-PYYW1chfKP7cMWqbW7yHnNh5v7qjJW8f27Mv160vTSW3JX9bz6QCkN4W3yrKmV25vJtRN6RRKCDDSjH1W1x2Rdy3scNzKW7cLGH22_P0-DW3TgRkj2BH5L0W3MfK-q6QtBYkW4VsJNn5tRSXLW2ptwYT7-18V4W3Jyb2b5c1xDZM9XCtYhzVNsW75f7r78csGDVVD2JF57dZRWvW5BbJtH3fDF-GW30D2Nn2tf-5XW4Wrj0H31GHfxW11PXZW1DylWwN91kcK-5LD0kW85GKv28HFk6-VGJMbw4x6kZpW4L1MlS4HzlXXf3hvFt-11> Subscribe to The Lab <https://www.thinkahead.com/TheLAB/>

[dan-wittenberg]

Ok I think I found the issue, some older linter module that hadn't gotten cleaned up, sent over changes and waiting for checks to pass now...

…

On Thu, Jan 17, 2019 at 6:35 PM Tim Meusel ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In manifests/config.pp <#463 (comment)> : > @@ -109,11 +118,11 @@ -> file { 'consul config.json': ensure => present, path => "${consul::config_dir}/config.json", - owner => $::consul::user_real, - group => $::consul::group_real, - mode => $::consul::config_mode, - content => consul::sorted_json($config_hash, $::consul::pretty_config, $::consul::pretty_config_indent), - require => File[$::consul::config_dir], + owner => $consul::user_real, something seems to be very wrong here. No leading :: for variables but for classes? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#463 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANCBg1AnQm1A8F06y0S4KjororLv0Ckiks5vERbcgaJpZM4aDFC7> .

-- *Daniel Wittenberg* *|* *Sr. Technical Architect* *|* *AHEAD* Work: 312.508.4996 | Mobile: 319.329.9776 | Fax: 312.924.5076 dan.wittenberg@ThinkAHEAD.com | ThinkAHEAD.com <http://info.thinkahead.com/e1t/c/*W6xgnfb3P660yN6FC2m6RB8ng0/*VZbrYd83jBHmW8yYcRc7tsC9Q0/5/f18dQhb0S5fw8XJ8hgW7-KP3h2qwv1yN32Gdlh5YWcwMf59TdXD6prW39Dr-N8pCDJGVYwxWD50wxKSW1wSwgX6PZxrZW1nrCGw96zRPSW6bT6L38RRjRDW5Ckvpl6vYDb4W7v70tS4RYYVxW3s1XjF51G0BFN4-0Bs5YSX-5W7m_B1R5c8d-SW377W4T2y-PYYW1chfKP7cMWqbW7yHnNh5v7qjJW8f27Mv160vTSW3JX9bz6QCkN4W3yrKmV25vJtRN6RRKCDDSjH1W1x2Rdy3scNzKW7cLGH22_P0-DW3TgRkj2BH5L0W3MfK-q6QtBYkW4VsJNn5tRSXLW2ptwYT7-18V4W3Jyb2b5c1xDZM9XCtYhzVNsW75f7r78csGDVVD2JF57dZRWvW5BbJtH3fDF-GW30D2Nn2tf-5XW4Wrj0H31GHfxW11PXZW1DylWwN91kcK-5LD0kW85GKv28HFk6-VGJMbw4x6kZpW4L1MlS4HzlXXf3hvFt-11> Subscribe to The Lab <https://www.thinkahead.com/TheLAB/>