Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grpc support #499

Closed
wants to merge 447 commits into from
Closed

Add grpc support #499

wants to merge 447 commits into from

Conversation

spuder
Copy link
Contributor

@spuder spuder commented Sep 27, 2019

Resolves issue #498

Dmitry A. Kulakov and others added 30 commits December 26, 2017 18:00
add the ui parameter and remove ui_* ones
8ed80d0
Remove ui parameter
28be771
@solarkennedy
Merge pull request voxpupuli#398 from rawleto/master
fc75ff1 
Added the ui parameter and removed ui_* ones
Add args parameter to consul::check
e3e0922 
382 added support for the `args` parameter to the `consul_validate_checks` function, but it isn't accepted by the `consul::check` resource.
@solarkennedy
Merge pull request voxpupuli#400 from joshuaspence/args
425ddab 
Add `args` parameter to `consul::check`
@tooooots
Removed command substitution in init script which caused consul to be…
bafcd81 
… launched as root
@solarkennedy
Merge pull request voxpupuli#401 from tooooots/master
db18996 
Removed command substitution in init script
@iwagnerclgx
Added experimental Windows support
bc8d0ce
@iwagnerclgx
Fixed alignment
dc3b286
@solarkennedy
Merge pull request voxpupuli#403 from iwagnerclgx/master
5180b34 
Added experimental Windows support
@solarkennedy
Update changelog for 3.3.0 release
1ddcbbe
@solarkennedy
[blacksmith] Bump version to 3.3.1
5584291
Add args support to consul watches
ed7ad93
@solarkennedy
Merge pull request voxpupuli#404 from scottybrisbane/watch-args
ed45513 
Add `args` parameter to `consul::watch`
@sw0x2A
Support space-separated list in addresses
4dbb981 
"In Consul 1.0 and later [addresses from config_hash] can be set to a space-separated list of addresses to bind to [...]" https://www.consul.io/docs/agent/options.html#addresses

Using a space-separated list in addresses for 'http' is currently not supported because it would break config in init scripts and other places. Limiting this to the first one mentioned fixes this.
@solarkennedy
Merge pull request voxpupuli#406 from sw0x2A/patch-1
173af5a 
Support space-separated list in addresses
Add new parameters to change consul permissions command
716f787
All binary params moved to class params
4ada5a0
@solarkennedy
Merge pull request voxpupuli#408 from cristianjuve/cristian/AddParams
6916f2b 
Add new parameters to configure consul permissions in the binary
@ajungren
Add AArch64 (arm64) support
d940491
@solarkennedy
Merge pull request voxpupuli#409 from ajungren/master
fb70a15 
Add AArch64 (arm64) support
@bastelfreak
add support for the beta UI
acb0ecc
@bastelfreak
update travis matrix to Vox Pupuli defaults
6de4f06
@solarkennedy
Merge pull request voxpupuli#417 from bastelfreak/beta_ui
56f6afc 
add support for the beta UI
@hfm
Change enableTagOverride to enable_tag_override in Consul 1.1.0 and l…
fbf157d 
…ater

Consul 1.1.0 has dropped support for enableTagOverride. Use enable_tag_override instead.
@solarkennedy
Merge pull request voxpupuli#418 from hfm/consul110
7e3fcda 
Change enableTagOverride to enable_tag_override in Consul 1.1.0 and later
@hfm
Use $consul::version instead of facter consul_version (Fix 09297fa)
9bda1fc 
Unless a host installed consul, facter `consul_version` returns undef and `versioncmp` raises evaluation error.

example:

> Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, 'versioncmp' parameter 'a' expects a String value, got Undef (file: /etc/puppetlabs/code/environments/ci/vendor/modules/consul/manifests/service.pp, line: 51, column: 6) (file: /etc/puppetlabs/code/environments/ci/vendor/modules/consul/manifests/init.pp, line: 238)
@solarkennedy
Merge pull request voxpupuli#419 from hfm/fix-consul110
99e13d6 
Use $consul::version instead of facter consul_version (Fix 09297fa)
@bastelfreak
bump archive upper boundary to <4.0.0
06f1510
@bastelfreak
test dependencies against master branch, not outdated releases
d473634
@spuder
Copy link
Contributor Author

spuder commented Nov 1, 2019

Rebased

@bastelfreak
Copy link
Member

@spuder can you take a look at the failing travis tests?

cmd-ntrf and others added 10 commits November 11, 2019 12:12
@cmd-ntrf
Add a sleep between tries of consul service reload
9ca2c5d 
As expressed issue voxpupuli#231, consul reload will fails if it happens while consul is still booting. However, the addition of multiple tries does not solve the issue as all tries can occur in a very short lapse of time.

In this PR, we introduce a sleep between each try, leaving consul up to 20 seconds between the first and the last reload to complete its boot, which should be enough.
@bastelfreak
Merge pull request voxpupuli#494 from cmd-ntrf/reload_try_sleep
e9c9f30 
Add a sleep between tries of consul service reload
@bastelfreak
systemd: Start consul after network is really up
dfa5a8b 
This change is based on systemd documentation from:
https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/
The network-online.target is reached after an actual ip configuration is
up. This is required if consul should bind to a specific ip address.
@bastelfreak
add .vendor to .gitignore
e1d0ce1
@solarkennedy
Merge pull request voxpupuli#512 from bastelfreak/systemd
9ff800b 
systemd: Start consul after network is really up
@bastelfreak
release 6.0.1
c9acd81
@solarkennedy
Merge pull request voxpupuli#513 from bastelfreak/rel601
2a1a070 
release 6.0.1
@bmx0r
fix(reload_service): remove typo in reload_options
d59d813
@solarkennedy
Merge pull request voxpupuli#516 from bmx0r/master
41a8a30 
fix(reload_service): remove typo in reload_options
@spuder
Merge branch 'master' into grpc
05df0e3
@spuder
Copy link
Contributor Author

spuder commented Feb 25, 2020

I've rebased and pushed again. The failing CI tests appear to be unrelated to any changes that I have made. I'm not quite sure why they are broken since it is referencing a file that doesn't even exist spec/fixtures/modules/consul/manifests/params.pp

     # Puppet::PreformattedError:
     #   Evaluation Error: Operator '[]' is not applicable to an Undef Value. (file: /home/travis/build/solarkennedy/puppet-consul/spec/fixtures/modules/consul/manifests/params.pp, line: 18, column: 17)
     #   ./vendor/bundle/ruby/2.4.0/gems/puppet-5.5.18/lib/puppet/pops/evaluator/runtime3_support.rb:39:in `optionally_fail'
  2) consul::watch on opensuse-13-x86_64  with valid type and handler is expected to contain File[/etc/consul/watch_my_watch.json] with content =~ /"handler" *: *"handler_path"/ and content =~ /"type" *: *"nodes"/
     Failure/Error:
       should contain_file('/etc/consul/watch_my_watch.json') \
           .with_content(/"handler" *: *"handler_path"/) \
           .with_content(/"type" *: *"nodes"/)
     Puppet::PreformattedError:
       Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Operator '[]' is not applicable to an Undef Value. (file: /home/travis/build/solarkennedy/puppet-consul/spec/fixtures/modules/consul/manifests/params.pp, line: 18, column: 17) (line: 2) on node travis-job-d47f9421-2068-400d-a553-40e0d674f975.c.travis-ci-prod-3.internal

@stale
Copy link

stale bot commented Feb 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 16, 2022
@stale stale bot closed this Apr 18, 2022
@wilfriedroset wilfriedroset mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

Assignees
No one assigned
Labels
enhancement New feature or request tests-fail wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.