add support for reload over https #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I restarted the failed travis jobs. |
bastelfreak
changed the title
spuder
pushed a commit
to spuder/puppet-consul
that referenced
this pull request
Feb 25, 2020
added support for reload over https
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When adding a service, or performing other change which requires consul to reload, consul is reloaded with the command:
However this assumes that consul allows connections via http, without encryption or identity verification.
For sensitive productions scenarios however, consul should only allow mutual tls connections. In this case the reloading will fail, as it tries to connect over http without valid certificate.
This merge request will allow the reload to happen over TLS, with the correct certificates.
How does it work?
If the http port is disabled (equal to -1) and
verify_incomingis set to true in the consul configuration, the reload will now happen automatically over TLS with the correct certificates.