Adding datacenters property for Consul policies #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Apr 14, 2022
types/policystruct.pp
Outdated
| @@ -3,6 +3,7 @@ | |||
| id => Optional[String[1]], | |||
| ensure => Optional[Enum['present', 'absent']], | |||
| description => Optional[String[0]], | |||
| datacenters => Optional[Array[String]], | |||
There was a problem hiding this comment.
I think empty string do not make any sense, so we can prohibit it:
Suggested change
| datacenters => Optional[Array[String]], | |
| datacenters => Optional[Array[String[1]]], |
…dding tests for the datacenters property
|
I've updated the test cases to account for the new datacenters parameter and ran the tests locally to ensure they pass. |
|
Thanks! |
1 similar comment
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using this puppet module with Consul version 1.11.4. On this version of Consul, maybe previous versions as well, there is a datacenters property for acl policies. I wanted to be able to set that when creating and updating policies. I have added a datacenters property to the consul_policy type and provider in this request.