Convert if nested inside else to elsif

voxpupuli · Dec 20, 2023 · 594ec3e · 594ec3e
1 parent 3bcf5bc
commit 594ec3e
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/lib/puppet/type/elastic_stack_keystore.rb b/lib/puppet/type/elastic_stack_keystore.rb
@@ -52,13 +52,11 @@ def insync?(value)
       else
         if resource[:purge]
           value == @should.first
+        elsif (@should.first.keys.sort - value.keys.sort).empty?
+          # compare the values of keys in common
+          (@should.first.values.sort - value.values.sort).empty?
         else
-          if (@should.first.keys.sort - value.keys.sort).empty?
-            # compare the values of keys in common
-            (@should.first.values.sort - value.values.sort).empty?
-          else
-            false
-          end
+          false
         end
       end
     end