Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more badges #1076

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Add some more badges #1076

merged 2 commits into from
Mar 13, 2020

Conversation

fatmcgav
Copy link
Contributor

Because everyone loves badges...

@fatmcgav fatmcgav self-assigned this Mar 13, 2020
@fatmcgav fatmcgav requested review from jmlrt and tylerjl March 13, 2020 10:51
README.md Outdated
@@ -3,6 +3,9 @@
[![Puppet Forge endorsed](https://img.shields.io/puppetforge/e/elastic/elasticsearch.svg)](https://forge.puppetlabs.com/elastic/elasticsearch)
[![Puppet Forge Version](https://img.shields.io/puppetforge/v/elastic/elasticsearch.svg)](https://forge.puppetlabs.com/elastic/elasticsearch)
[![Puppet Forge Downloads](https://img.shields.io/puppetforge/dt/elastic/elasticsearch.svg)](https://forge.puppetlabs.com/elastic/elasticsearch)
[![Puppet Forge Score](https://img.shields.io/puppetforge/f/elastic/elastic_stack.svg)](https://forge.puppetlabs.com/elastic/elastic_stack)
[![Build Status](https://travis-ci.org/elastic/elasticsearch.png?branch=master)](https://travis-ci.org/elastic/elasticsearch)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this message expected when clicking on the travis link?

Screenshot 2020-03-13 at 12 34 11

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, looks like I typo'd the link... Let me fix that :)

@@ -3,6 +3,9 @@
[![Puppet Forge endorsed](https://img.shields.io/puppetforge/e/elastic/elasticsearch.svg)](https://forge.puppetlabs.com/elastic/elasticsearch)
[![Puppet Forge Version](https://img.shields.io/puppetforge/v/elastic/elasticsearch.svg)](https://forge.puppetlabs.com/elastic/elasticsearch)
[![Puppet Forge Downloads](https://img.shields.io/puppetforge/dt/elastic/elasticsearch.svg)](https://forge.puppetlabs.com/elastic/elasticsearch)
[![Puppet Forge Score](https://img.shields.io/puppetforge/f/elastic/elastic_stack.svg)](https://forge.puppetlabs.com/elastic/elastic_stack)
[![Build Status](https://travis-ci.org/elastic/elasticsearch.png?branch=master)](https://travis-ci.org/elastic/elasticsearch)
<!-- [![Code Coverage](https://coveralls.io/repos/github/elastic/elasticsearch/badge.svg?branch=master)](https://coveralls.io/github/elastic/elasticsearch) -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this link commented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coveralls isn't currently setup, but I plan to do it in the near future :)

That'll teach me to copy'n'paste!
Copy link
Contributor

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fatmcgav fatmcgav merged commit 31e35a5 into voxpupuli:master Mar 13, 2020
@fatmcgav fatmcgav deleted the add_badges branch March 13, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants