-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make sure plugins installed before service is started #1106
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
@fatmcgav can you please take a look at this change. Currently this blocking from us to upgrade the module, since we install some plugins. |
@shamil thanks for putting in a fix. The changes all look sane though. Thanks |
@fatmcgav added test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tweak to the test, but otherwise this LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for approval @fatmcgav |
@shamil I've just merged this PR. Thanks again for the contribution. WRT a bug-fix release, I'll look to get that done this week, as there's a couple of other PR's I want to follow up on aswell :) |
Pull request acceptance prerequisites: